Skip to content

✨ Add amp-ad implementation for Adserver.Online #40434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
powerivq merged 4 commits into from
Dec 1, 2025
Merged

✨ Add amp-ad implementation for Adserver.Online #40434

powerivq merged 4 commits into from
Dec 1, 2025

Conversation

@adserver-online
Copy link
Contributor

@adserver-online adserver-online commented Nov 15, 2025 •
edited
Loading

This PR adds support for the Adserver.Online ad server in amp-ad.

Changes included

  • Provides vendor bootstrap in 3p/vendors/aso.js.
  • Adds vendor configuration in ads/_config.js.
  • Implements the main logic in ads/vendors/aso.js.
  • Provides publisher documentation at ads/vendors/aso.md.
  • Adds an example to examples/amp-ad/ads.amp.html.
  • Updates extensions/amp-ad/amp-ad.md to include a link to the Adserver.Online documentation.

Notes

  • Implements renderStart and noContentAvailable APIs for improved UX.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@erwinmombay erwinmombay requested a review from powerivq November 26, 2025 05:14
@erwinmombay
Copy link
Member

erwinmombay commented Nov 26, 2025

@powerivq could you take a look at this

powerivq
powerivq requested changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@powerivq powerivq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM w/ minor nits.

@powerivq
Copy link
Contributor

powerivq commented Dec 1, 2025

@adserver-online plz rebase against latest main. tests should pass.

@powerivq powerivq merged commit ea70b30 into ampproject:main Dec 1, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@powerivq powerivq powerivq approved these changes

Assignees

No one assigned

Labels

PR use: In Beta / Experimental PR use: In LTS PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adserver-online @CLAassistant @erwinmombay @powerivq @ampprojectbot